diff options
| author | Corey Minyard <minyard@acm.org> | 2023-06-20 16:59:53 +0200 |
|---|---|---|
| committer | Corey Minyard <minyard@acm.org> | 2023-06-20 16:59:53 +0200 |
| commit | e87443a5f68da7bacefe933c90453ae7215263b3 (patch) | |
| tree | ce6812020935abebfd719f7387e576e8205fde45 | |
| parent | ipmi: make ipmi_class a static const structure (diff) | |
| download | linux-e87443a5f68da7bacefe933c90453ae7215263b3.tar.xz linux-e87443a5f68da7bacefe933c90453ae7215263b3.zip | |
ipmi: Change request_module to request_module_nowait
When probing for an ACPI-specified IPMI device, the code would request
that the acpi_ipmi module be loaded ACPI operations through IPMI can be
performed. This could happen through module load context, for instance,
if an I2C module is loaded that caused the IPMI interface to be probed.
This is not allowed because a synchronous module load in this context
can result in an deadlock, and I was getting a warning:
[ 23.967853] WARNING: CPU: 0 PID: 21 at kernel/module/kmod.c:144 __request_module+0x1de/0x2d0
[ 23.968852] Modules linked in: i2c_i801 ipmi_ssif
The IPMI driver is not dependent on acpi_ipmi, so just change the called
to request_module_nowait to make the load asynchronous.
Signed-off-by: Corey Minyard <minyard@acm.org>
| -rw-r--r-- | drivers/char/ipmi/ipmi_si_platform.c | 2 | ||||
| -rw-r--r-- | drivers/char/ipmi/ipmi_ssif.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/drivers/char/ipmi/ipmi_si_platform.c b/drivers/char/ipmi/ipmi_si_platform.c index 505cc978c97a..70f73911457b 100644 --- a/drivers/char/ipmi/ipmi_si_platform.c +++ b/drivers/char/ipmi/ipmi_si_platform.c @@ -381,7 +381,7 @@ static int acpi_ipmi_probe(struct platform_device *pdev) dev_info(dev, "%pR regsize %d spacing %d irq %d\n", res, io.regsize, io.regspacing, io.irq); - request_module("acpi_ipmi"); + request_module_nowait("acpi_ipmi"); return ipmi_si_add_smi(&io); } diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c index 3d21c39e2060..df8dd50b4cbe 100644 --- a/drivers/char/ipmi/ipmi_ssif.c +++ b/drivers/char/ipmi/ipmi_ssif.c @@ -1439,7 +1439,7 @@ static bool check_acpi(struct ssif_info *ssif_info, struct device *dev) if (acpi_handle) { ssif_info->addr_source = SI_ACPI; ssif_info->addr_info.acpi_info.acpi_handle = acpi_handle; - request_module("acpi_ipmi"); + request_module_nowait("acpi_ipmi"); return true; } #endif |