diff options
author | Alan Stern <stern@rowland.harvard.edu> | 2013-03-22 18:30:56 +0100 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-03-25 21:35:05 +0100 |
commit | 79bcf7b02ba3d45bafe81a2753cedb8ef49548e3 (patch) | |
tree | da06b30b0fdd12dfb3286bed6a940bd2e4e0dfe0 /COPYING | |
parent | USB: EHCI: changes related to qh_refresh() (diff) | |
download | linux-79bcf7b02ba3d45bafe81a2753cedb8ef49548e3.tar.xz linux-79bcf7b02ba3d45bafe81a2753cedb8ef49548e3.zip |
USB: EHCI: change return value of qh_completions()
This patch (as1658) cleans up the usage of qh_completions() in
ehci-hcd. Currently the function's return value indicates whether any
URBs were given back; the idea was that the caller can scan the QH
over again to handle any URBs that were dequeued by a completion
handler. This is not necessary; when qh_completions() is ready to
give back dequeued URBs, it does its own rescanning.
Therefore the new return value will be a flag indicating whether the
caller needs to unlink the QH. This is more convenient than forcing
the caller to check qh->needs_rescan, and it makes a lot more sense --
why should "needs_rescan" imply that an unlink is needed? The callers
are also changed to remove the unneeded rescans.
Lastly, the check for whether qh->qtd_list is non-empty is removed
from the start of qh_completions(). Two of the callers have to make
this test anyway, so the same test can simply be added to the other
two callers.
Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'COPYING')
0 files changed, 0 insertions, 0 deletions