diff options
author | Christoph Hellwig <hch@lst.de> | 2016-12-08 23:20:32 +0100 |
---|---|---|
committer | Jens Axboe <axboe@fb.com> | 2016-12-09 16:30:51 +0100 |
commit | f9d03f96b988002027d4b28ea1b7a24729a4c9b5 (patch) | |
tree | e4995a30bbe58290594e2ef29de5ae2785c6c9db /COPYING | |
parent | blk-wbt: don't throttle discard or write zeroes (diff) | |
download | linux-f9d03f96b988002027d4b28ea1b7a24729a4c9b5.tar.xz linux-f9d03f96b988002027d4b28ea1b7a24729a4c9b5.zip |
block: improve handling of the magic discard payload
Instead of allocating a single unused biovec for discard requests, send
them down without any payload. Instead we allow the driver to add a
"special" payload using a biovec embedded into struct request (unioned
over other fields never used while in the driver), and overloading
the number of segments for this case.
This has a couple of advantages:
- we don't have to allocate the bio_vec
- the amount of special casing for discard requests in the block
layer is significantly reduced
- using this same scheme for other request types is trivial,
which will be important for implementing the new WRITE_ZEROES
op on devices where it actually requires a payload (e.g. SCSI)
- we can get rid of playing games with the request length, as
we'll never touch it and completions will work just fine
- it will allow us to support ranged discard operations in the
future by merging non-contiguous discard bios into a single
request
- last but not least it removes a lot of code
This patch is the common base for my WIP series for ranges discards and to
remove discard_zeroes_data in favor of always using REQ_OP_WRITE_ZEROES,
so it would be good to get it in quickly.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'COPYING')
0 files changed, 0 insertions, 0 deletions