diff options
author | Guilherme G Piccoli <gpiccoli@linux.vnet.ibm.com> | 2016-11-10 19:46:43 +0100 |
---|---|---|
committer | Jeff Kirsher <jeffrey.t.kirsher@intel.com> | 2017-01-06 11:18:51 +0100 |
commit | 69b97cf6dbce7403845a28bbc75d57f5be7b12ac (patch) | |
tree | 219d6bc601eca2eec7d9b393d553929575cdb311 /COPYING | |
parent | igb: reset the PHY before reading the PHY ID (diff) | |
download | linux-69b97cf6dbce7403845a28bbc75d57f5be7b12ac.tar.xz linux-69b97cf6dbce7403845a28bbc75d57f5be7b12ac.zip |
igb: re-assign hw address pointer on reset after PCI error
Whenever the igb driver detects the result of a read operation returns
a value composed only by F's (like 0xFFFFFFFF), it will detach the
net_device, clear the hw_addr pointer and warn to the user that adapter's
link is lost - those steps happen on igb_rd32().
In case a PCI error happens on Power architecture, there's a recovery
mechanism called EEH, that will reset the PCI slot and call driver's
handlers to reset the adapter and network functionality as well.
We observed that once hw_addr is NULL after the error is detected on
igb_rd32(), it's never assigned back, so in the process of resetting
the network functionality we got a NULL pointer dereference in both
igb_configure_tx_ring() and igb_configure_rx_ring(). In order to avoid
such bug, this patch re-assigns the hw_addr value in the slot_reset
handler.
Reported-by: Anthony H Thai <ahthai@us.ibm.com>
Reported-by: Harsha Thyagaraja <hathyaga@in.ibm.com>
Signed-off-by: Guilherme G Piccoli <gpiccoli@linux.vnet.ibm.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Diffstat (limited to 'COPYING')
0 files changed, 0 insertions, 0 deletions