diff options
author | José Bollo <jose.bollo@open.eurogiciel.org> | 2014-04-03 13:48:41 +0200 |
---|---|---|
committer | Casey Schaufler <casey@schaufler-ca.com> | 2014-04-11 23:35:05 +0200 |
commit | 9598f4c9e7069aee8639be1e04e8af26b5a77fa2 (patch) | |
tree | 2a23f4d21a289d80e007e674cf6b7e4108404a97 /CREDITS | |
parent | bugfix patch for SMACK (diff) | |
download | linux-9598f4c9e7069aee8639be1e04e8af26b5a77fa2.tar.xz linux-9598f4c9e7069aee8639be1e04e8af26b5a77fa2.zip |
SMACK: Fix handling value==NULL in post setxattr
The function `smack_inode_post_setxattr` is called each
time that a setxattr is done, for any value of name.
The kernel allow to put value==NULL when size==0
to set an empty attribute value. The systematic
call to smk_import_entry was causing the dereference
of a NULL pointer hence a KERNEL PANIC!
The problem can be produced easily by issuing the
command `setfattr -n user.data file` under bash prompt
when SMACK is active.
Moving the call to smk_import_entry as proposed by this
patch is correcting the behaviour because the function
smack_inode_post_setxattr is called for the SMACK's
attributes only if the function smack_inode_setxattr validated
the value and its size (what will not be the case when size==0).
It also has a benefical effect to not fill the smack hash
with garbage values coming from any extended attribute
write.
Change-Id: Iaf0039c2be9bccb6cee11c24a3b44d209101fe47
Signed-off-by: José Bollo <jose.bollo@open.eurogiciel.org>
Diffstat (limited to 'CREDITS')
0 files changed, 0 insertions, 0 deletions