diff options
author | NeilBrown <neilb@suse.com> | 2017-02-06 03:41:39 +0100 |
---|---|---|
committer | Shaohua Li <shli@fb.com> | 2017-02-13 18:17:53 +0100 |
commit | 9356863c9409efc79029c01a85d015efae977e69 (patch) | |
tree | 985e9e3ca39ac84fa0ad866294e07cbd87874bb6 /Documentation/00-INDEX | |
parent | md/r5cache: improve journal device efficiency (diff) | |
download | linux-9356863c9409efc79029c01a85d015efae977e69.tar.xz linux-9356863c9409efc79029c01a85d015efae977e69.zip |
md: ensure md devices are freed before module is unloaded.
Commit: cbd199837750 ("md: Fix unfortunate interaction with evms")
change mddev_put() so that it would not destroy an md device while
->ctime was non-zero.
Unfortunately, we didn't make sure to clear ->ctime when unloading
the module, so it is possible for an md device to remain after
module unload. An attempt to open such a device will trigger
an invalid memory reference in:
get_gendisk -> kobj_lookup -> exact_lock -> get_disk
when tring to access disk->fops, which was in the module that has
been removed.
So ensure we clear ->ctime in md_exit(), and explain how that is useful,
as it isn't immediately obvious when looking at the code.
Fixes: cbd199837750 ("md: Fix unfortunate interaction with evms")
Tested-by: Guoqing Jiang <gqjiang@suse.com>
Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: Shaohua Li <shli@fb.com>
Diffstat (limited to 'Documentation/00-INDEX')
0 files changed, 0 insertions, 0 deletions