diff options
author | Eric Biggers <ebiggers@google.com> | 2018-03-29 20:31:42 +0200 |
---|---|---|
committer | Theodore Ts'o <tytso@mit.edu> | 2018-03-29 20:31:42 +0200 |
commit | ce3fd194fcc6fbdc00ce095a852f22df97baa401 (patch) | |
tree | 253d8a212f3e27bf2fc56e8176a4b44f8e15c944 /Documentation/IPMI.txt | |
parent | ext4: add validity checks for bitmap block numbers (diff) | |
download | linux-ce3fd194fcc6fbdc00ce095a852f22df97baa401.tar.xz linux-ce3fd194fcc6fbdc00ce095a852f22df97baa401.zip |
ext4: limit xattr size to INT_MAX
ext4 isn't validating the sizes of xattrs where the value of the xattr
is stored in an external inode. This is problematic because
->e_value_size is a u32, but ext4_xattr_get() returns an int. A very
large size is misinterpreted as an error code, which ext4_get_acl()
translates into a bogus ERR_PTR() for which IS_ERR() returns false,
causing a crash.
Fix this by validating that all xattrs are <= INT_MAX bytes.
This issue has been assigned CVE-2018-1095.
https://bugzilla.kernel.org/show_bug.cgi?id=199185
https://bugzilla.redhat.com/show_bug.cgi?id=1560793
Reported-by: Wen Xu <wen.xu@gatech.edu>
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@vger.kernel.org
Fixes: e50e5129f384 ("ext4: xattr-in-inode support")
Diffstat (limited to 'Documentation/IPMI.txt')
0 files changed, 0 insertions, 0 deletions