diff options
author | Ingo Molnar <mingo@kernel.org> | 2014-04-17 10:25:53 +0200 |
---|---|---|
committer | Ingo Molnar <mingo@kernel.org> | 2014-04-17 10:28:42 +0200 |
commit | ea431643d6c38728195e2c456801c3ef66bb9991 (patch) | |
tree | 00a65a9939a45dc15064853da648fb38720c5ef7 /Documentation/aoe | |
parent | x86: Remove the PCI reboot method from the default chain (diff) | |
download | linux-ea431643d6c38728195e2c456801c3ef66bb9991.tar.xz linux-ea431643d6c38728195e2c456801c3ef66bb9991.zip |
x86/mce: Fix CMCI preemption bugs
The following commit:
27f6c573e0f7 ("x86, CMCI: Add proper detection of end of CMCI storms")
Added two preemption bugs:
- machine_check_poll() does a get_cpu_var() without a matching
put_cpu_var(), which causes preemption imbalance and crashes upon
bootup.
- it does percpu ops without disabling preemption. Preemption is not
disabled due to the mistaken use of a raw spinlock.
To fix these bugs fix the imbalance and change
cmci_discover_lock to a regular spinlock.
Reported-by: Owen Kibel <qmewlo@gmail.com>
Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: Chen, Gong <gong.chen@linux.intel.com>
Cc: Josh Boyer <jwboyer@fedoraproject.org>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Alexander Todorov <atodorov@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Link: http://lkml.kernel.org/n/tip-jtjptvgigpfkpvtQxpEk1at2@git.kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
--
arch/x86/kernel/cpu/mcheck/mce.c | 4 +---
arch/x86/kernel/cpu/mcheck/mce_intel.c | 18 +++++++++---------
2 files changed, 10 insertions(+), 12 deletions(-)
Diffstat (limited to 'Documentation/aoe')
0 files changed, 0 insertions, 0 deletions