diff options
| author | Jakub Kicinski <jakub.kicinski@netronome.com> | 2019-04-20 01:52:19 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-04-21 05:36:51 +0200 |
| commit | 12c7686111326148b4b5db189130522a4ad1be4a (patch) | |
| tree | e7eb8437b2d9d6f8b592019a768c27815e697cfd /Documentation/devicetree/bindings/net/ethernet.txt | |
| parent | net/tls: avoid potential deadlock in tls_set_device_offload_rx() (diff) | |
| download | linux-12c7686111326148b4b5db189130522a4ad1be4a.tar.xz linux-12c7686111326148b4b5db189130522a4ad1be4a.zip | |
net/tls: don't leak IV and record seq when offload fails
When device refuses the offload in tls_set_device_offload_rx()
it calls tls_sw_free_resources_rx() to clean up software context
state.
Unfortunately, tls_sw_free_resources_rx() does not free all
the state tls_set_sw_offload() allocated - it leaks IV and
sequence number buffers. All other code paths which lead to
tls_sw_release_resources_rx() (which tls_sw_free_resources_rx()
calls) free those right before the call.
Avoid the leak by moving freeing of iv and rec_seq into
tls_sw_release_resources_rx().
Fixes: 4799ac81e52a ("tls: Add rx inline crypto offload")
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Dirk van der Merwe <dirk.vandermerwe@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'Documentation/devicetree/bindings/net/ethernet.txt')
0 files changed, 0 insertions, 0 deletions