diff options
| author | Michael Walle <michael@walle.cc> | 2021-11-11 09:37:13 +0100 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2021-11-12 19:18:03 +0100 |
| commit | 6c53b45c71b4920b5e62f0ea8079a1da382b9434 (patch) | |
| tree | 88fa899b8a1afdf75f87aa0123590884049a571f /Documentation/devicetree/bindings/spi/spi-rockchip.yaml | |
| parent | spi: spi-geni-qcom: fix error handling in spi_geni_grab_gpi_chan() (diff) | |
| download | linux-6c53b45c71b4920b5e62f0ea8079a1da382b9434.tar.xz linux-6c53b45c71b4920b5e62f0ea8079a1da382b9434.zip | |
spi: fix use-after-free of the add_lock mutex
Commit 6098475d4cb4 ("spi: Fix deadlock when adding SPI controllers on
SPI buses") introduced a per-controller mutex. But mutex_unlock() of
said lock is called after the controller is already freed:
spi_unregister_controller(ctlr)
-> put_device(&ctlr->dev)
-> spi_controller_release(dev)
-> mutex_unlock(&ctrl->add_lock)
Move the put_device() after the mutex_unlock().
Fixes: 6098475d4cb4 ("spi: Fix deadlock when adding SPI controllers on SPI buses")
Signed-off-by: Michael Walle <michael@walle.cc>
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Lukas Wunner <lukas@wunner.de>
Cc: stable@vger.kernel.org # v5.15
Link: https://lore.kernel.org/r/20211111083713.3335171-1-michael@walle.cc
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'Documentation/devicetree/bindings/spi/spi-rockchip.yaml')
0 files changed, 0 insertions, 0 deletions