diff options
author | Guenter Roeck <linux@roeck-us.net> | 2021-09-09 05:57:43 +0200 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2021-09-16 21:52:06 +0200 |
commit | 3c0d2a46c0141913dc6fd126c57d0615677d946e (patch) | |
tree | 7176048edd93285918f8de3617c4afe9ee6a7778 /Documentation/driver-api/misc_devices.rst | |
parent | drm/rockchip: cdn-dp-core: Make cdn_dp_core_resume __maybe_unused (diff) | |
download | linux-3c0d2a46c0141913dc6fd126c57d0615677d946e.tar.xz linux-3c0d2a46c0141913dc6fd126c57d0615677d946e.zip |
net: 6pack: Fix tx timeout and slot time
tx timeout and slot time are currently specified in units of HZ. On
Alpha, HZ is defined as 1024. When building alpha:allmodconfig, this
results in the following error message.
drivers/net/hamradio/6pack.c: In function 'sixpack_open':
drivers/net/hamradio/6pack.c:71:41: error:
unsigned conversion from 'int' to 'unsigned char'
changes value from '256' to '0'
In the 6PACK protocol, tx timeout is specified in units of 10 ms and
transmitted over the wire:
https://www.linux-ax25.org/wiki/6PACK
Defining a value dependent on HZ doesn't really make sense, and
presumably comes from the (very historical) situation where HZ was
originally 100.
Note that the SIXP_SLOTTIME use explicitly is about 10ms granularity:
mod_timer(&sp->tx_t, jiffies + ((when + 1) * HZ) / 100);
and the SIXP_TXDELAY walue is sent as a byte over the wire.
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'Documentation/driver-api/misc_devices.rst')
0 files changed, 0 insertions, 0 deletions