diff options
| author | Andreas Gruenbacher <agruenba@redhat.com> | 2024-03-28 20:46:25 +0100 |
|---|---|---|
| committer | Andreas Gruenbacher <agruenba@redhat.com> | 2024-05-29 15:34:55 +0200 |
| commit | 713f8834389f4b34bc8b449412202543c8b32214 (patch) | |
| tree | 3fd04cf01fd5ef0343f6cbaaaf8a0f3660d913c8 /Documentation/filesystems | |
| parent | Revert "GFS2: Don't add all glocks to the lru" (diff) | |
| download | linux-713f8834389f4b34bc8b449412202543c8b32214.tar.xz linux-713f8834389f4b34bc8b449412202543c8b32214.zip | |
gfs2: Get rid of demote_ok checks
The demote_ok glock operation is only still used to prevent the inode
glocks of the "jindex" and "rindex" directories from getting recycled
while they are still referenced by sdp->sd_jindex and sdp->sd_rindex.
However, the LRU walking code will no longer recycle glocks which are
referenced, so the demote_ok glock operation is obsolete and can be
removed.
Each of a glock's holders in the gl_holders list is holding a reference
on the glock, so when the list of holders isn't empty in demote_ok(),
the existing reference count check will already prevent the glock from
getting released. This means that demote_ok() is obsolete as well.
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Diffstat (limited to 'Documentation/filesystems')
| -rw-r--r-- | Documentation/filesystems/gfs2-glocks.rst | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/Documentation/filesystems/gfs2-glocks.rst b/Documentation/filesystems/gfs2-glocks.rst index 17ce3413608a..adc0d4c4d979 100644 --- a/Documentation/filesystems/gfs2-glocks.rst +++ b/Documentation/filesystems/gfs2-glocks.rst @@ -61,8 +61,6 @@ Field Purpose go_sync Called before remote state change (e.g. to sync dirty data) go_xmote_bh Called after remote state change (e.g. to refill cache) go_inval Called if remote state change requires invalidating the cache -go_demote_ok Returns boolean value of whether its ok to demote a glock - (e.g. checks timeout, and that there is no cached data) go_instantiate Called when a glock has been acquired go_held Called every time a glock holder is acquired go_dump Called to print content of object for debugfs file, or on @@ -95,7 +93,6 @@ Operation GLF_LOCK bit lock held gl_lockref.lock spinlock held go_sync Yes No go_xmote_bh Yes No go_inval Yes No -go_demote_ok Sometimes Yes go_instantiate No No go_held No No go_dump Sometimes Yes |