diff options
| author | Oleg Nesterov <oleg@tv-sign.ru> | 2008-02-23 22:03:29 +0100 |
|---|---|---|
| committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2008-02-24 02:52:36 +0100 |
| commit | 02c608c1fefe821a4c6fc34c45a0dea3cebf4764 (patch) | |
| tree | 8fd360da8bc83dd45ecec5621791baa73ddfac70 /Documentation/memory-barriers.txt | |
| parent | memcgroup: return negative error code in mem_cgroup_create() (diff) | |
| download | linux-02c608c1fefe821a4c6fc34c45a0dea3cebf4764.tar.xz linux-02c608c1fefe821a4c6fc34c45a0dea3cebf4764.zip | |
documentation: atomic_add_unless() doesn't imply mb() on failure
(sorry for being offtpoic, but while experts are here...)
A "typical" implementation of atomic_add_unless() can return 0 immediately
after the first atomic_read() (before doing cmpxchg). In that case it doesn't
provide any barrier semantics. See include/asm-ia64/atomic.h as an example.
We should either change the implementation, or fix the docs.
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Acked-by: Nick Piggin <npiggin@suse.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to '')
| -rw-r--r-- | Documentation/memory-barriers.txt | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/Documentation/memory-barriers.txt b/Documentation/memory-barriers.txt index 4e17beba2379..1f506f7830ec 100644 --- a/Documentation/memory-barriers.txt +++ b/Documentation/memory-barriers.txt @@ -1493,7 +1493,7 @@ explicit lock operations, described later). These include: atomic_dec_and_test(); atomic_sub_and_test(); atomic_add_negative(); - atomic_add_unless(); + atomic_add_unless(); /* when succeeds (returns 1) */ test_and_set_bit(); test_and_clear_bit(); test_and_change_bit(); |