diff options
| author | Al Viro <viro@zeniv.linux.org.uk> | 2014-12-13 05:02:36 +0100 |
|---|---|---|
| committer | Al Viro <viro@zeniv.linux.org.uk> | 2015-02-04 07:34:13 +0100 |
| commit | a8866ff6a5bce7d0ec465a63bc482a85c09b0d39 (patch) | |
| tree | ba7534a7245d5230860564bb1e936a22a1c97e0c /Documentation/networking/spider_net.txt | |
| parent | Merge tag 'linux-can-next-for-3.20-20150128' of git://git.kernel.org/pub/scm/... (diff) | |
| download | linux-a8866ff6a5bce7d0ec465a63bc482a85c09b0d39.tar.xz linux-a8866ff6a5bce7d0ec465a63bc482a85c09b0d39.zip | |
netlink: make the check for "send from tx_ring" deterministic
As it is, zero msg_iovlen means that the first iovec in the kernel
array of iovecs is left uninitialized, so checking if its ->iov_base
is NULL is random. Since the real users of that thing are doing
sendto(fd, NULL, 0, ...), they are getting msg_iovlen = 1 and
msg_iov[0] = {NULL, 0}, which is what this test is trying to catch.
As suggested by davem, let's just check that msg_iovlen was 1 and
msg_iov[0].iov_base was NULL - _that_ is well-defined and it catches
what we want to catch.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'Documentation/networking/spider_net.txt')
0 files changed, 0 insertions, 0 deletions