summaryrefslogtreecommitdiffstats
path: root/Documentation/slow-work.txt
diff options
context:
space:
mode:
authorTejun Heo <tj@kernel.org>2009-10-15 16:37:32 +0200
committerJeff Garzik <jgarzik@redhat.com>2009-10-16 12:21:54 +0200
commit4f7c2874995ac48a4622755b8bd159eb2fb6d8f4 (patch)
treeab355d2b7392a8db4807bb7b31eb61190afa01e0 /Documentation/slow-work.txt
parentsata_nv: make sure link is brough up online when skipping hardreset (diff)
downloadlinux-4f7c2874995ac48a4622755b8bd159eb2fb6d8f4.tar.xz
linux-4f7c2874995ac48a4622755b8bd159eb2fb6d8f4.zip
libata: fix PMP initialization
Commit 842faa6c1a1d6faddf3377948e5cf214812c6c90 fixed error handling during attach by not committing detected device class to dev->class while attaching a new device. However, this change missed the PMP class check in the configuration loop causing a new PMP device to go through ata_dev_configure() as if it were an ATA or ATAPI device. As PMP device doesn't have a regular IDENTIFY data, this makes ata_dev_configure() tries to configure a PMP device using an invalid data. For the most part, it wasn't too harmful and went unnoticed but this ends up clearing dev->flags which may have ATA_DFLAG_AN set by sata_pmp_attach(). This means that SATA_PMP_FEAT_NOTIFY ends up being disabled on PMPs and on PMPs which honor the flag breaks hotplug support. This problem was discovered and reported by Ethan Hsiao. Signed-off-by: Tejun Heo <tj@kernel.org> Reported-by: Ethan Hsiao <ethanhsiao@jmicron.com> Cc: stable@kernel.org Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Diffstat (limited to 'Documentation/slow-work.txt')
0 files changed, 0 insertions, 0 deletions