diff options
| author | Lars Ellenberg <lars.ellenberg@linbit.com> | 2017-08-29 10:20:44 +0200 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2017-08-29 23:34:46 +0200 |
| commit | cde81d99afa4112eecef3f45129b5827f6ac158e (patch) | |
| tree | 07f4b2a5f05448cda6791ed5ec146ca55e987c09 /Documentation/smsc_ece1099.txt | |
| parent | drbd: fix potential deadlock when trying to detach during handshake (diff) | |
| download | linux-cde81d99afa4112eecef3f45129b5827f6ac158e.tar.xz linux-cde81d99afa4112eecef3f45129b5827f6ac158e.zip | |
drbd: fix race between handshake and admin disconnect/down
conn_try_disconnect() could potentialy hit the BUG_ON()
in _conn_set_state() where it iterates over _drbd_set_state()
and "asserts" via BUG_ON() that the latter was successful.
If the STATE_SENT bit was not yet visible to conn_is_valid_transition()
early in _conn_request_state(), but became visible before conn_set_state()
later in that call path, we could hit the BUG_ON() after _drbd_set_state(),
because it returned SS_IN_TRANSIENT_STATE.
To avoid that race, we better protect set_bit(SENT_STATE) with the spinlock.
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'Documentation/smsc_ece1099.txt')
0 files changed, 0 insertions, 0 deletions