diff options
author | Justin Stitt <justinstitt@google.com> | 2022-07-08 00:14:56 +0200 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2022-07-08 13:14:36 +0200 |
commit | 9d899dbe23016856effc01eafec31c587a3c8791 (patch) | |
tree | eb444d0322a56f63730aa526b670105287c092f5 /Documentation/trace/coresight | |
parent | eth: sp7021: switch to netif_napi_add_tx() (diff) | |
download | linux-9d899dbe23016856effc01eafec31c587a3c8791.tar.xz linux-9d899dbe23016856effc01eafec31c587a3c8791.zip |
l2tp: l2tp_debugfs: fix Clang -Wformat warnings
When building with Clang we encounter the following warnings:
| net/l2tp/l2tp_debugfs.c:187:40: error: format specifies type 'unsigned
| short' but the argument has type 'u32' (aka 'unsigned int')
| [-Werror,-Wformat] seq_printf(m, " nr %hu, ns %hu\n", session->nr,
| session->ns);
-
| net/l2tp/l2tp_debugfs.c:196:32: error: format specifies type 'unsigned
| short' but the argument has type 'int' [-Werror,-Wformat]
| session->l2specific_type, l2tp_get_l2specific_len(session));
-
| net/l2tp/l2tp_debugfs.c:219:6: error: format specifies type 'unsigned
| short' but the argument has type 'u32' (aka 'unsigned int')
| [-Werror,-Wformat] session->nr, session->ns,
Both session->nr and ->nc are of type `u32`. The currently used format
specifier is `%hu` which describes a `u16`. My proposed fix is to listen
to Clang and use the correct format specifier `%u`.
For the warning at line 196, l2tp_get_l2specific_len() returns an int
and should therefore be using the `%d` format specifier.
Link: https://github.com/ClangBuiltLinux/linux/issues/378
Signed-off-by: Justin Stitt <justinstitt@google.com>
Acked-by: Guillaume Nault <gnault@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'Documentation/trace/coresight')
0 files changed, 0 insertions, 0 deletions