diff options
| author | Matti Vaittinen <mazziesaccount@gmail.com> | 2022-10-03 10:11:33 +0200 |
|---|---|---|
| committer | Jonathan Cameron <Jonathan.Cameron@huawei.com> | 2022-10-17 09:51:26 +0200 |
| commit | 54246b9034da08087ceb2083478c0d13403e12b4 (patch) | |
| tree | e00a5ba5f98038ea5c74a624e91f38a35f90a9d5 /Documentation/usb/gadget_multi.rst | |
| parent | iio: temperature: ltc2983: allocate iio channels once (diff) | |
| download | linux-54246b9034da08087ceb2083478c0d13403e12b4.tar.xz linux-54246b9034da08087ceb2083478c0d13403e12b4.zip | |
iio: at91-sama5d2_adc: Fix unsafe buffer attributes
The iio_triggered_buffer_setup_ext() was changed by
commit 15097c7a1adc ("iio: buffer: wrap all buffer attributes into iio_dev_attr")
to silently expect that all attributes given in buffer_attrs array are
device-attributes. This expectation was not forced by the API - and some
drivers did register attributes created by IIO_CONST_ATTR().
The added attribute "wrapping" does not copy the pointer to stored
string constant and when the sysfs file is read the kernel will access
to invalid location.
Change the IIO_CONST_ATTRs from the driver to IIO_DEVICE_ATTR in order
to prevent the invalid memory access.
Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
Fixes: 15097c7a1adc ("iio: buffer: wrap all buffer attributes into iio_dev_attr")
Tested-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Link: https://lore.kernel.org/r/be69775aa302159f088b8b91894e6ec449bca65b.1664782676.git.mazziesaccount@gmail.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Diffstat (limited to 'Documentation/usb/gadget_multi.rst')
0 files changed, 0 insertions, 0 deletions