diff options
author | Thomas Gleixner <tglx@linutronix.de> | 2023-01-16 19:11:32 +0100 |
---|---|---|
committer | Thomas Gleixner <tglx@linutronix.de> | 2023-01-16 20:40:44 +0100 |
commit | 6c796996ee7033bcbbc3cd733513eb43f8160f5e (patch) | |
tree | 876bdeb3b0e0a080c021c58ac748e3c899fc43cb /Documentation/x86 | |
parent | x86/pci/xen: Set MSI_FLAG_PCI_MSIX support in Xen MSI domain (diff) | |
download | linux-6c796996ee7033bcbbc3cd733513eb43f8160f5e.tar.xz linux-6c796996ee7033bcbbc3cd733513eb43f8160f5e.zip |
x86/pci/xen: Fixup fallout from the PCI/MSI overhaul
David reported that the recent PCI/MSI rework results in MSI descriptor
leakage under XEN.
This is caused by:
1) The missing MSI_FLAG_FREE_MSI_DESCS flag in the XEN MSI domain info,
which is required now that PCI/MSI delegates descriptor freeing to
the core MSI code.
2) Not disassociating the interrupts on teardown, by setting the
msi_desc::irq to 0. This was not required before because the teardown
was unconditional and did not check whether a MSI descriptor was still
connected to a Linux interrupt.
On further inspection it came to light that the MSI_FLAG_DEV_SYSFS is
missing in the XEN MSI domain info as well to restore the pre 6.2 status
quo.
Add the missing MSI flags and disassociate the MSI descriptor from the
Linux interrupt in the XEN specific teardown function.
Fixes: b2bdda205c0c ("PCI/MSI: Let the MSI core free descriptors")
Fixes: 2f2940d16823 ("genirq/msi: Remove filter from msi_free_descs_free_range()")
Fixes: ffd84485e6be ("PCI/MSI: Let the irq code handle sysfs groups")
Reported-by: David Woodhouse <dwmw@amazon.co.uk>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: David Woodhouse <dwmw@amazon.co.uk>
Link: https://lore.kernel.org/r/871qnunycr.ffs@tglx
Diffstat (limited to 'Documentation/x86')
0 files changed, 0 insertions, 0 deletions