diff options
| author | Linus Torvalds <torvalds@linux-foundation.org> | 2020-03-12 23:51:26 +0100 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2020-03-12 23:51:26 +0100 |
| commit | 807f030b44ccbb26a346df6f6438628315d9ad98 (patch) | |
| tree | 5c5bf61456bf8f6649fab5e60e8ef0e8985a713a /Documentation | |
| parent | Merge tag 'for-linus-5.6-2' of git://github.com/cminyard/linux-ipmi (diff) | |
| parent | cifs_atomic_open(): fix double-put on late allocation failure (diff) | |
| download | linux-807f030b44ccbb26a346df6f6438628315d9ad98.tar.xz linux-807f030b44ccbb26a346df6f6438628315d9ad98.zip | |
Merge branch 'fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
Pull vfs fixes from Al Viro:
"A couple of fixes for old crap in ->atomic_open() instances"
* 'fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs:
cifs_atomic_open(): fix double-put on late allocation failure
gfs2_atomic_open(): fix O_EXCL|O_CREAT handling on cold dcache
Diffstat (limited to 'Documentation')
| -rw-r--r-- | Documentation/filesystems/porting.rst | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/Documentation/filesystems/porting.rst b/Documentation/filesystems/porting.rst index f18506083ced..26c093969573 100644 --- a/Documentation/filesystems/porting.rst +++ b/Documentation/filesystems/porting.rst @@ -850,3 +850,11 @@ business doing so. d_alloc_pseudo() is internal-only; uses outside of alloc_file_pseudo() are very suspect (and won't work in modules). Such uses are very likely to be misspelled d_alloc_anon(). + +--- + +**mandatory** + +[should've been added in 2016] stale comment in finish_open() nonwithstanding, +failure exits in ->atomic_open() instances should *NOT* fput() the file, +no matter what. Everything is handled by the caller. |