summaryrefslogtreecommitdiffstats
path: root/Makefile
diff options
context:
space:
mode:
authorLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>2013-11-28 18:11:45 +0100
committerSimon Horman <horms+renesas@verge.net.au>2013-12-14 01:58:12 +0100
commitcaec70381b469d6ed1bd3d0441a19aa6de0bbff3 (patch)
tree8a68b6cc78511ef077c56fecbc854dc991050dd2 /Makefile
parentserial: sh-sci: Fix warnings due to improper casts and printk formats (diff)
downloadlinux-caec70381b469d6ed1bd3d0441a19aa6de0bbff3.tar.xz
linux-caec70381b469d6ed1bd3d0441a19aa6de0bbff3.zip
serial: sh-sci: Don't enable/disable port from within break timer
The break timer accesses hardware registers and thus requires the port to be enabled. It currently ensures this by enabling the port at the beginning of the timer handler, and disabling it at the end. However, the enable/disable operations call the runtime PM sync functions, which are not allowed in atomic context. The current situation is thus broken. This change relies on non-atomic code to enable/disable the port. The break timer will only be started from the IRQ handler, which already runs with the port enabled. We just need to ensure that the port won't be disabled with the timer running, and that's easily done by just cancelling the timer in the port disable function. Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Acked-by: Magnus Damm <damm@opensource.se> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Diffstat (limited to 'Makefile')
0 files changed, 0 insertions, 0 deletions