diff options
author | Mark Brown <broonie@kernel.org> | 2024-01-22 22:54:30 +0100 |
---|---|---|
committer | Mark Brown <broonie@kernel.org> | 2024-01-22 22:54:30 +0100 |
commit | 7c70825d1603001e09907b383ed5d1bd283d61a0 (patch) | |
tree | d8f91461236fa43695d544e1bf632011c753fc52 /Makefile | |
parent | ASoC: codecs: fix ES8326 performance and pop noise (diff) | |
parent | ASoC: codecs: wcd9335: drop unused gain hack remnant (diff) | |
download | linux-7c70825d1603001e09907b383ed5d1bd283d61a0.tar.xz linux-7c70825d1603001e09907b383ed5d1bd283d61a0.zip |
ASoC: qcom: volume fixes and codec cleanups
Merge series from Johan Hovold <johan+linaro@kernel.org>:
To reduce the risk of speaker damage the PA gain needs to be limited on
machines like the Lenovo Thinkpad X13s until we have active speaker
protection in place.
Limit the gain to the current default setting provided by the UCM
configuration which most user have so far been using (due to a bug in
the configuration files which prevented hardware volume control [1]).
The wsa883x PA volume control also turned out to be broken, which meant
that the default setting used by UCM configuration is actually the
lowest level (-3 dB). With the codec driver fixed, hardware volume
control also works as expected.
Note that the new wsa884x driver most likely suffers from a similar bug,
I'll send a fix for that once I've got that confirmed.
Included is also a related fix for the LPASS WSA macro driver, which
was changing the digital gain setting behind the back of user space and
which can result in excessive (or too low) digital gain.
There are further Qualcomm codec drivers that similarly appear to
manipulate various gain settings, but on closer inspection it turns out
that they only write back the current settings. Tests reveal that these
writes are indeed needed for any prior updates to take effect (at least
for the WSA and RX macros).
[1] https://github.com/alsa-project/alsa-ucm-conf/pull/382
Diffstat (limited to 'Makefile')
0 files changed, 0 insertions, 0 deletions