diff options
author | Al Viro <viro@zeniv.linux.org.uk> | 2010-09-18 14:40:07 +0200 |
---|---|---|
committer | Matt Turner <mattst88@gmail.com> | 2010-09-19 05:08:28 +0200 |
commit | 392fb6e35400edbee183baba24b34a0fa2053813 (patch) | |
tree | e11587c8b7ca75ab41b23f9e09e2c6a9365e2187 /arch/alpha/Kconfig.debug | |
parent | alpha: belated ERESTART_RESTARTBLOCK race fix (diff) | |
download | linux-392fb6e35400edbee183baba24b34a0fa2053813.tar.xz linux-392fb6e35400edbee183baba24b34a0fa2053813.zip |
alpha: unb0rk sigsuspend() and rt_sigsuspend()
Old code used to set regs->r0 and regs->r19 to force the right
return value. Leaving that after switch to ERESTARTNOHAND
was a Bad Idea(tm), since now that screws the restart - if we
hit the case when get_signal_to_deliver() returns 0, we will
step back to syscall insn, with v0 set to EINTR and a3 to 1.
The latter won't matter, since EINTR is 4, aka __NR_write.
Testcase:
#include <signal.h>
#define _GNU_SOURCE
#include <unistd.h>
#include <sys/syscall.h>
main()
{
sigset_t mask;
sigemptyset(&mask);
sigaddset(&mask, SIGCONT);
sigprocmask(SIG_SETMASK, &mask, NULL);
kill(0, SIGCONT);
syscall(__NR_sigsuspend, 1, "b0rken\n", 7);
}
results on alpha in immediate message to stdout...
Fix is obvious; moreover, since we don't need regs anymore, we can
switch to normal prototypes for these guys and lose the wrappers.
Even better, rt_sigsuspend() is identical to generic version in
kernel/signal.c now.
Tested-by: Michael Cree <mcree@orcon.net.nz>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Matt Turner <mattst88@gmail.com>
Diffstat (limited to 'arch/alpha/Kconfig.debug')
0 files changed, 0 insertions, 0 deletions