summaryrefslogtreecommitdiffstats
path: root/arch/arc/kernel/kprobes.c
diff options
context:
space:
mode:
authorPeter Zijlstra <peterz@infradead.org>2021-05-25 09:25:19 +0200
committerPeter Zijlstra <peterz@infradead.org>2021-06-01 16:00:08 +0200
commitec6aba3d2be1ed75b3f4c894bb64a36d40db1f55 (patch)
tree0fd56814090efcd59ce2f2b29906043853764b23 /arch/arc/kernel/kprobes.c
parentuprobes: Update uprobe_write_opcode() kernel-doc comment (diff)
downloadlinux-ec6aba3d2be1ed75b3f4c894bb64a36d40db1f55.tar.xz
linux-ec6aba3d2be1ed75b3f4c894bb64a36d40db1f55.zip
kprobes: Remove kprobe::fault_handler
The reason for kprobe::fault_handler(), as given by their comment: * We come here because instructions in the pre/post * handler caused the page_fault, this could happen * if handler tries to access user space by * copy_from_user(), get_user() etc. Let the * user-specified handler try to fix it first. Is just plain bad. Those other handlers are ran from non-preemptible context and had better use _nofault() functions. Also, there is no upstream usage of this. Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Reviewed-by: Christoph Hellwig <hch@lst.de> Acked-by: Masami Hiramatsu <mhiramat@kernel.org> Link: https://lore.kernel.org/r/20210525073213.561116662@infradead.org
Diffstat (limited to 'arch/arc/kernel/kprobes.c')
-rw-r--r--arch/arc/kernel/kprobes.c10
1 files changed, 0 insertions, 10 deletions
diff --git a/arch/arc/kernel/kprobes.c b/arch/arc/kernel/kprobes.c
index cabef45f11df..9f5b39f38736 100644
--- a/arch/arc/kernel/kprobes.c
+++ b/arch/arc/kernel/kprobes.c
@@ -324,16 +324,6 @@ int __kprobes kprobe_fault_handler(struct pt_regs *regs, unsigned long trapnr)
kprobes_inc_nmissed_count(cur);
/*
- * We come here because instructions in the pre/post
- * handler caused the page_fault, this could happen
- * if handler tries to access user space by
- * copy_from_user(), get_user() etc. Let the
- * user-specified handler try to fix it first.
- */
- if (cur->fault_handler && cur->fault_handler(cur, regs, trapnr))
- return 1;
-
- /*
* In case the user-specified fault handler returned zero,
* try to fix up.
*/