diff options
| author | Linus Walleij <linus.walleij@linaro.org> | 2015-12-22 15:35:47 +0100 |
|---|---|---|
| committer | Olof Johansson <olof@lixom.net> | 2015-12-22 23:57:21 +0100 |
| commit | 86d5e657d27851beb0e3e7bf48f13263acc5196a (patch) | |
| tree | 645c7c166e93056ed3c08c02bc5173847f640e9e /arch/arm/common | |
| parent | Merge tag 'davinci-for-v4.5/fixes' of git://git.kernel.org/pub/scm/linux/kern... (diff) | |
| download | linux-86d5e657d27851beb0e3e7bf48f13263acc5196a.tar.xz linux-86d5e657d27851beb0e3e7bf48f13263acc5196a.zip | |
ARM: scoop: Be sure to clamp return value
As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.
Cc: arm@kernel.org
Cc: Richard Purdie <rpurdie@rpsys.net>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Olof Johansson <olof@lixom.net>
Diffstat (limited to 'arch/arm/common')
| -rw-r--r-- | arch/arm/common/scoop.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/arm/common/scoop.c b/arch/arm/common/scoop.c index 45f4c21e393c..e0df333202b8 100644 --- a/arch/arm/common/scoop.c +++ b/arch/arm/common/scoop.c @@ -84,7 +84,7 @@ static int scoop_gpio_get(struct gpio_chip *chip, unsigned offset) struct scoop_dev *sdev = container_of(chip, struct scoop_dev, gpio); /* XXX: I'm unsure, but it seems so */ - return ioread16(sdev->base + SCOOP_GPRR) & (1 << (offset + 1)); + return !!(ioread16(sdev->base + SCOOP_GPRR) & (1 << (offset + 1))); } static int scoop_gpio_direction_input(struct gpio_chip *chip, |