diff options
| author | Ananth N Mavinakayanahalli <ananth@linux.ibm.com> | 2021-01-25 14:06:43 +0100 |
|---|---|---|
| committer | Michael Ellerman <mpe@ellerman.id.au> | 2021-01-30 01:40:04 +0100 |
| commit | 718aae916fa6619c57c348beaedd675835cf1aa1 (patch) | |
| tree | 60a77b05c95e0163382e4f6ac99902156122c1cd /arch/arm/mach-pxa | |
| parent | powerpc/sstep: Check instruction validity against ISA version before emulation (diff) | |
| download | linux-718aae916fa6619c57c348beaedd675835cf1aa1.tar.xz linux-718aae916fa6619c57c348beaedd675835cf1aa1.zip | |
powerpc/sstep: Fix incorrect return from analyze_instr()
We currently just percolate the return value from analyze_instr()
to the caller of emulate_step(), especially if it is a -1.
For one particular case (opcode = 4) for instructions that aren't
currently emulated, we are returning 'should not be single-stepped'
while we should have returned 0 which says 'did not emulate, may
have to single-step'.
Fixes: 930d6288a26787 ("powerpc: sstep: Add support for maddhd, maddhdu, maddld instructions")
Signed-off-by: Ananth N Mavinakayanahalli <ananth@linux.ibm.com>
Suggested-by: Michael Ellerman <mpe@ellerman.id.au>
Tested-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Reviewed-by: Sandipan Das <sandipan@linux.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/161157999039.64773.14950289716779364766.stgit@thinktux.local
Diffstat (limited to 'arch/arm/mach-pxa')
0 files changed, 0 insertions, 0 deletions