summaryrefslogtreecommitdiffstats
path: root/arch/arm/mach-shmobile/r8a7791.h
diff options
context:
space:
mode:
authorGeorge Spelvin <linux@horizon.com>2014-10-07 13:26:38 +0200
committerTejun Heo <tj@kernel.org>2014-10-07 23:10:00 +0200
commit1c40279960bcd7d52dbdf1d466b20d24b99176c8 (patch)
tree39035a38f06cf7c84bb246c1b3029986fbd83209 /arch/arm/mach-shmobile/r8a7791.h
parentAHCI: Do not acquire ata_host::lock from single IRQ handler (diff)
downloadlinux-1c40279960bcd7d52dbdf1d466b20d24b99176c8.tar.xz
linux-1c40279960bcd7d52dbdf1d466b20d24b99176c8.zip
libata: Un-break ATA blacklist
lib/glob.c provides a new glob_match() function, with arguments in (pattern, string) order. It replaced a private function with arguments in (string, pattern) order, but I didn't swap the call site... The result was the entire ATA blacklist was effectively disabled. The lesson for today is "I f***ed up *how* badly *how* many months ago?", er, I mean "Nobody Tests RC Kernels On Legacy Hardware". This was not a subtle break, but it made it through an entire RC cycle unreported, presumably because all the people doing testing have full-featured hardware. (FWIW, the reason for the argument swap was because fnmatch() does it that way, and for a while implementing a full fnmatch() was being considered.) Fixes: 428ac5fc056e0 (libata: Use glob_match from lib/glob.c) Reported-by: Steven Honeyman <stevenhoneyman@gmail.com> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=71371#c21 Signed-off-by: George Spelvin <linux@horizon.com> Cc: <stable@vger.kernel.org> # 3.17 Tested-by: Steven Honeyman <stevenhoneyman@gmail.com> Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'arch/arm/mach-shmobile/r8a7791.h')
0 files changed, 0 insertions, 0 deletions