diff options
| author | Konstantin Khlebnikov <k.khlebnikov@samsung.com> | 2014-08-28 13:49:36 +0200 |
|---|---|---|
| committer | Russell King <rmk+kernel@arm.linux.org.uk> | 2014-09-02 21:55:23 +0200 |
| commit | 7e66cbc93f876e24c2f8434cf011b94be242005e (patch) | |
| tree | 8a1d32cedd03f94fdac776d6879be18c096512dd /arch/arm/mm/proc-fa526.S | |
| parent | ARM: 8130/1: cpuidle/cpuidle-big_little: fix reading cpu id part number (diff) | |
| download | linux-7e66cbc93f876e24c2f8434cf011b94be242005e.tar.xz linux-7e66cbc93f876e24c2f8434cf011b94be242005e.zip | |
ARM: 8132/1: LPAE: drop wrong carry flag correction after adding TTBR1_OFFSET
ARM: LPAE: drop wrong carry flag correction after adding TTBR1_OFFSET
In commit 7fb00c2fca4b6c58be521eb3676cf4b4ba8dde3b ("ARM: 8114/1: LPAE:
load upper bits of early TTBR0/TTBR1") part which fixes carrying in adding
TTBR1_OFFSET to TTRR1 was wrong:
addls ttbr1, ttbr1, #TTBR1_OFFSET
adcls tmp, tmp, #0
addls doesn't update flags, adcls adds carry from cmp above:
cmp ttbr1, tmp @ PHYS_OFFSET > PAGE_OFFSET?
Condition 'ls' means carry flag is clear or zero flag is set, thus only one
case is affected: when PHYS_OFFSET == PAGE_OFFSET.
It seems safer to remove this fixup. Bug is here for ages and nobody
complained. Let's fix it separately.
Reported-and-Tested-by: Jassi Brar <jassisinghbrar@gmail.com>
Signed-off-by: Konstantin Khlebnikov <k.khlebnikov@samsung.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Diffstat (limited to 'arch/arm/mm/proc-fa526.S')
0 files changed, 0 insertions, 0 deletions