summaryrefslogtreecommitdiffstats
path: root/arch/arm/net
diff options
context:
space:
mode:
authorDavid Vrabel <david.vrabel@citrix.com>2013-02-14 04:18:58 +0100
committerDavid S. Miller <davem@davemloft.net>2013-02-14 19:16:49 +0100
commit3e55f8b306cf305832a4ac78aa82e1b40e818ece (patch)
tree7363625e54905ef6f3d151c86a6788542d68fc4f /arch/arm/net
parentxen-netback: correctly return errors from netbk_count_requests() (diff)
downloadlinux-3e55f8b306cf305832a4ac78aa82e1b40e818ece.tar.xz
linux-3e55f8b306cf305832a4ac78aa82e1b40e818ece.zip
xen-netback: cancel the credit timer when taking the vif down
If the credit timer is left armed after calling xen_netbk_remove_xenvif(), then it may fire and attempt to schedule the vif which will then oops as vif->netbk == NULL. This may happen both in the fatal error path and during normal disconnection from the front end. The sequencing during shutdown is critical to ensure that: a) vif->netbk doesn't become unexpectedly NULL; and b) the net device/vif is not freed. 1. Mark as unschedulable (netif_carrier_off()). 2. Synchronously cancel the timer. 3. Remove the vif from the schedule list. 4. Remove it from it netback thread group. 5. Wait for vif->refcnt to become 0. Signed-off-by: David Vrabel <david.vrabel@citrix.com> Acked-by: Ian Campbell <ian.campbell@citrix.com> Reported-by: Christopher S. Aker <caker@theshore.net> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'arch/arm/net')
0 files changed, 0 insertions, 0 deletions