summaryrefslogtreecommitdiffstats
path: root/arch/arm64/crypto
diff options
context:
space:
mode:
authorColin Ian King <colin.king@canonical.com>2014-08-24 22:38:35 +0200
committerWill Deacon <will.deacon@arm.com>2014-08-26 12:42:22 +0200
commit031cb428383b2fcf36a4ce09aeedaa548d9ed1d1 (patch)
treeddffeb591e1bcf14de716469a99181e58699b3b9 /arch/arm64/crypto
parentLinux 3.17-rc2 (diff)
downloadlinux-031cb428383b2fcf36a4ce09aeedaa548d9ed1d1.tar.xz
linux-031cb428383b2fcf36a4ce09aeedaa548d9ed1d1.zip
arm64/crypto: remove redundant update of data
Originally found by cppcheck: [arch/arm64/crypto/sha2-ce-glue.c:153]: (warning) Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? Updating data by blocks * SHA256_BLOCK_SIZE at the end of sha2_finup is redundant code and can be removed. Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Will Deacon <will.deacon@arm.com>
Diffstat (limited to 'arch/arm64/crypto')
-rw-r--r--arch/arm64/crypto/sha2-ce-glue.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/arch/arm64/crypto/sha2-ce-glue.c b/arch/arm64/crypto/sha2-ce-glue.c
index c294e67d3925..ae67e88c28b9 100644
--- a/arch/arm64/crypto/sha2-ce-glue.c
+++ b/arch/arm64/crypto/sha2-ce-glue.c
@@ -150,7 +150,6 @@ static void sha2_finup(struct shash_desc *desc, const u8 *data,
kernel_neon_begin_partial(28);
sha2_ce_transform(blocks, data, sctx->state, NULL, len);
kernel_neon_end();
- data += blocks * SHA256_BLOCK_SIZE;
}
static int sha224_finup(struct shash_desc *desc, const u8 *data,