diff options
author | Mark Rutland <mark.rutland@arm.com> | 2020-03-10 13:09:12 +0100 |
---|---|---|
committer | Theodore Ts'o <tytso@mit.edu> | 2020-03-19 04:28:17 +0100 |
commit | ab9a7e27044b87ff2be47b8f8e095400e7fccc44 (patch) | |
tree | 3a349c6d12b30f89c466fdb4e2fb70d3712d32dd /arch/arm64/kernel/armv8_deprecated.c | |
parent | random: fix data races at timer_rand_state (diff) | |
download | linux-ab9a7e27044b87ff2be47b8f8e095400e7fccc44.tar.xz linux-ab9a7e27044b87ff2be47b8f8e095400e7fccc44.zip |
random: avoid warnings for !CONFIG_NUMA builds
As crng_initialize_secondary() is only called by do_numa_crng_init(),
and the latter is under ifdeffery for CONFIG_NUMA, when CONFIG_NUMA is
not selected the compiler will warn that the former is unused:
| drivers/char/random.c:820:13: warning: 'crng_initialize_secondary' defined but not used [-Wunused-function]
| 820 | static void crng_initialize_secondary(struct crng_state *crng)
| | ^~~~~~~~~~~~~~~~~~~~~~~~~
Stephen reports that this happens for x86_64 noallconfig builds.
We could move crng_initialize_secondary() and crng_init_try_arch() under
the CONFIG_NUMA ifdeffery, but this has the unfortunate property of
separating them from crng_initialize_primary() and
crng_init_try_arch_early() respectively. Instead, let's mark
crng_initialize_secondary() as __maybe_unused.
Link: https://lore.kernel.org/r/20200310121747.GA49602@lakrids.cambridge.arm.com
Fixes: 5cbe0f13b51a ("random: split primary/secondary crng init paths")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Cc: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Diffstat (limited to 'arch/arm64/kernel/armv8_deprecated.c')
0 files changed, 0 insertions, 0 deletions