diff options
author | Arnd Bergmann <arnd@arndb.de> | 2020-10-26 17:49:21 +0100 |
---|---|---|
committer | Thierry Reding <treding@nvidia.com> | 2020-11-10 20:15:17 +0100 |
commit | 9294996f0be40e9da818ed891c82397ab63c00d0 (patch) | |
tree | 008ed08c77d314cfaeb302afccb68915ca05bf59 /arch/arm64/kernel/smp.c | |
parent | Linux 5.10-rc1 (diff) | |
download | linux-9294996f0be40e9da818ed891c82397ab63c00d0.tar.xz linux-9294996f0be40e9da818ed891c82397ab63c00d0.zip |
firmware: tegra: fix strncpy()/strncat() confusion
The way that bpmp_populate_debugfs_inband() uses strncpy()
and strncat() makes no sense since the size argument for
the first is insufficient to contain the trailing '/'
and the second passes the length of the input rather than
the output, which triggers a warning:
In function 'strncat',
inlined from 'bpmp_populate_debugfs_inband' at ../drivers/firmware/tegra/bpmp-debugfs.c:422:4:
include/linux/string.h:289:30: warning: '__builtin_strncat' specified bound depends on the length of the source argument [-Wstringop-overflow=]
289 | #define __underlying_strncat __builtin_strncat
| ^
include/linux/string.h:367:10: note: in expansion of macro '__underlying_strncat'
367 | return __underlying_strncat(p, q, count);
| ^~~~~~~~~~~~~~~~~~~~
drivers/firmware/tegra/bpmp-debugfs.c: In function 'bpmp_populate_debugfs_inband':
include/linux/string.h:288:29: note: length computed here
288 | #define __underlying_strlen __builtin_strlen
| ^
include/linux/string.h:321:10: note: in expansion of macro '__underlying_strlen'
321 | return __underlying_strlen(p);
Simplify this to use an snprintf() instead.
Fixes: 5e37b9c137ee ("firmware: tegra: Add support for in-band debug")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Jon Hunter <jonathanh@nvidia.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
Diffstat (limited to 'arch/arm64/kernel/smp.c')
0 files changed, 0 insertions, 0 deletions