diff options
| author | H. Nikolaus Schaller <hns@goldelico.com> | 2020-12-12 10:55:25 +0100 |
|---|---|---|
| committer | Tony Lindgren <tony@atomide.com> | 2020-12-18 08:12:06 +0100 |
| commit | 07af7810e0a5bc4e51682c90f9fa19fc4cb93f18 (patch) | |
| tree | 3f043e681385aa252b63d98dcb266aa7d999e4fb /arch/arm | |
| parent | Linux 5.10 (diff) | |
| download | linux-07af7810e0a5bc4e51682c90f9fa19fc4cb93f18.tar.xz linux-07af7810e0a5bc4e51682c90f9fa19fc4cb93f18.zip | |
DTS: ARM: gta04: remove legacy spi-cs-high to make display work again
This reverts
commit f1f028ff89cb ("DTS: ARM: gta04: introduce legacy spi-cs-high to make display work again")
which had to be intruduced after
commit 6953c57ab172 ("gpio: of: Handle SPI chipselect legacy bindings")
broke the GTA04 display. This contradicted the data sheet but was the only
way to get it as an spi client operational again.
The panel data sheet defines the chip-select to be active low.
Now, with the arrival of
commit 766c6b63aa04 ("spi: fix client driver breakages when using GPIO descriptors")
the logic of interaction between spi-cs-high and the gpio descriptor flags
has been changed a second time, making the display broken again. So we have
to remove the original fix which in retrospect was a workaround of a bug in
the spi subsystem and not a feature of the panel or bug in the device tree.
With this fix the device tree is back in sync with the data sheet and
spi subsystem code.
Fixes: 766c6b63aa04 ("spi: fix client driver breakages when using GPIO descriptors")
CC: stable@vger.kernel.org
Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Diffstat (limited to 'arch/arm')
| -rw-r--r-- | arch/arm/boot/dts/omap3-gta04.dtsi | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi index c8745bc800f7..003202d12990 100644 --- a/arch/arm/boot/dts/omap3-gta04.dtsi +++ b/arch/arm/boot/dts/omap3-gta04.dtsi @@ -124,7 +124,6 @@ spi-max-frequency = <100000>; spi-cpol; spi-cpha; - spi-cs-high; backlight= <&backlight>; label = "lcd"; |