diff options
| author | Miaoqian Lin <linmq006@gmail.com> | 2022-06-01 06:48:58 +0200 |
|---|---|---|
| committer | Tony Lindgren <tony@atomide.com> | 2022-06-28 06:36:26 +0200 |
| commit | 9705db1eff38d6b9114121f9e253746199b759c9 (patch) | |
| tree | 451f108ffecf3594ff2ac78dc4064b2b9879fc20 /arch/arm | |
| parent | Linux 5.19-rc1 (diff) | |
| download | linux-9705db1eff38d6b9114121f9e253746199b759c9.tar.xz linux-9705db1eff38d6b9114121f9e253746199b759c9.zip | |
ARM: OMAP2+: Fix refcount leak in omapdss_init_of
omapdss_find_dss_of_node() calls of_find_compatible_node() to get device
node. of_find_compatible_node() returns a node pointer with refcount
incremented, we should use of_node_put() on it when done.
Add missing of_node_put() in later error path and normal path.
Fixes: e0c827aca0730 ("drm/omap: Populate DSS children in omapdss driver")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Message-Id: <20220601044858.3352-1-linmq006@gmail.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Diffstat (limited to 'arch/arm')
| -rw-r--r-- | arch/arm/mach-omap2/display.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/arch/arm/mach-omap2/display.c b/arch/arm/mach-omap2/display.c index 21413a9b7b6c..ed2cb2649cf6 100644 --- a/arch/arm/mach-omap2/display.c +++ b/arch/arm/mach-omap2/display.c @@ -259,11 +259,13 @@ static int __init omapdss_init_of(void) if (!pdev) { pr_err("Unable to find DSS platform device\n"); + of_node_put(node); return -ENODEV; } r = of_platform_populate(node, NULL, NULL, &pdev->dev); put_device(&pdev->dev); + of_node_put(node); if (r) { pr_err("Unable to populate DSS submodule devices\n"); return r; |