diff options
author | Peter Zijlstra <peterz@infradead.org> | 2015-06-02 12:50:13 +0200 |
---|---|---|
committer | Ingo Molnar <mingo@kernel.org> | 2015-06-07 15:46:30 +0200 |
commit | cee34d88cabd1ba5fc93e09b5b12232bc9338c7c (patch) | |
tree | 278d17b06e20285f8c2822d724ecc41a69b27e9d /arch/c6x/mm | |
parent | Merge tag 'driver-core-4.1-rc7' of git://git.kernel.org/pub/scm/linux/kernel/... (diff) | |
download | linux-cee34d88cabd1ba5fc93e09b5b12232bc9338c7c.tar.xz linux-cee34d88cabd1ba5fc93e09b5b12232bc9338c7c.zip |
lockdep: Fix a race between /proc/lock_stat and module unload
The lock_class iteration of /proc/lock_stat is not serialized against
the lockdep_free_key_range() call from module unload.
Therefore it can happen that we find a class of which ->name/->key are
no longer valid.
There is a further bug in zap_class() that left ->name dangling. Cure
this. Use RCU_INIT_POINTER() because NULL.
Since lockdep_free_key_range() is rcu_sched serialized, we can read
both ->name and ->key under rcu_read_lock_sched() (preempt-disable)
and be assured that if we observe a !NULL value it stays safe to use
for as long as we hold that lock.
If we observe both NULL, skip the entry.
Reported-by: Jerome Marchand <jmarchan@redhat.com>
Tested-by: Jerome Marchand <jmarchan@redhat.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20150602105013.GS3644@twins.programming.kicks-ass.net
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'arch/c6x/mm')
0 files changed, 0 insertions, 0 deletions