diff options
| author | Volodymyr G. Lukiianyk <volodymyrgl@gmail.com> | 2008-10-16 07:01:15 +0200 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-10-16 20:21:29 +0200 |
| commit | f4cfb18d7917ecb397b3497e931a2a23175709b7 (patch) | |
| tree | bb891b0f478e2ed7fa9dcefacc0b8342ce1b43d6 /arch/h8300/platform | |
| parent | mm: do_generic_file_read() never gets a NULL 'filp' argument (diff) | |
| download | linux-f4cfb18d7917ecb397b3497e931a2a23175709b7.tar.xz linux-f4cfb18d7917ecb397b3497e931a2a23175709b7.zip | |
uclinux: fix gzip header parsing in binfmt_flat.c
There are off-by-one errors in decompress_exec() when calculating the length of
optional "original file name" and "comment" fields: the "ret" index is not
incremented when terminating '\0' character is reached. The check of the buffer
overflow (after an "extra-field" length was taken into account) is also fixed.
I've encountered this off-by-one error when tried to reuse
gzip-header-parsing part of the decompress_exec() function. There was an
"original file name" field in the payload (with miscalculated length) and
zlib_inflate() returned Z_DATA_ERROR. But after the fix similar to this
one all worked fine.
Signed-off-by: Volodymyr G Lukiianyk <volodymyrgl@gmail.com>
Acked-by: Greg Ungerer <gerg@snapgear.com>
Acked-by: David Howells <dhowells@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'arch/h8300/platform')
0 files changed, 0 insertions, 0 deletions