diff options
| author | KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> | 2007-03-23 04:17:46 +0100 |
|---|---|---|
| committer | Tony Luck <tony.luck@intel.com> | 2007-03-30 00:15:24 +0200 |
| commit | 83d2cd3de48a7fb73838c45145780cfa9b1f61fd (patch) | |
| tree | 85d056d9a718f69c7242a8bb6cde17fc928fa4cc /arch/ia64 | |
| parent | [IA64] Fix possible invalid memory access in ia64_setup_msi_irq() (diff) | |
| download | linux-83d2cd3de48a7fb73838c45145780cfa9b1f61fd.tar.xz linux-83d2cd3de48a7fb73838c45145780cfa9b1f61fd.zip | |
[IA64] bugfix stack layout upside-down
ia64 expects following vm layout:
== low memory
[register-stack grows up]
[memory-stack grows down]
== high memory
But the code assigns the base of the register stack at the
maximum stack size offset from the fixed address where the
stack *might* start. Stack randomization will result in the
memory stack starting at a lower address than this, and if the
user has set a low stack limit with "ulimit -s", then you can
end up with the register stack above the memory stack (or if
you were very unlucky right on top of it!).
Fix: Calculate the base address for the register stack starting
from the actual address of the memory stack.
Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>
Diffstat (limited to 'arch/ia64')
| -rw-r--r-- | arch/ia64/mm/init.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/ia64/mm/init.c b/arch/ia64/mm/init.c index c8da621aab17..4f36987eea72 100644 --- a/arch/ia64/mm/init.c +++ b/arch/ia64/mm/init.c @@ -155,7 +155,7 @@ ia64_set_rbs_bot (void) if (stack_size > MAX_USER_STACK_SIZE) stack_size = MAX_USER_STACK_SIZE; - current->thread.rbs_bot = STACK_TOP - stack_size; + current->thread.rbs_bot = PAGE_ALIGN(current->mm->start_stack - stack_size); } /* |