diff options
| author | David Howells <dhowells@redhat.com> | 2013-03-13 22:59:47 +0100 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2013-03-13 23:21:49 +0100 |
| commit | ca044f9a9ed492f0f7e52df999c10ca6f7cfc5c0 (patch) | |
| tree | 0693ff6fd14f52d164a98d593ee1dcf639cff5fc /arch/m32r/include/uapi/asm/stat.h | |
| parent | UAPI: fix endianness conditionals in linux/acct.h (diff) | |
| download | linux-ca044f9a9ed492f0f7e52df999c10ca6f7cfc5c0.tar.xz linux-ca044f9a9ed492f0f7e52df999c10ca6f7cfc5c0.zip | |
UAPI: fix endianness conditionals in linux/raid/md_p.h
In the UAPI header files, __BIG_ENDIAN and __LITTLE_ENDIAN must be
compared against __BYTE_ORDER in preprocessor conditionals where these are
exposed to userspace (that is they're not inside __KERNEL__ conditionals).
However, in the main kernel the norm is to check for
"defined(__XXX_ENDIAN)" rather than comparing against __BYTE_ORDER and
this has incorrectly leaked into the userspace headers.
The definition of struct mdp_superblock_s in linux/raid/md_p.h is wrong in
this way. Note that userspace will likely interpret the ordering of the
fields incorrectly as the big-endian variant on a little-endian machines -
depending on header inclusion order.
[!!!] NOTE [!!!] This patch may adversely change the userspace API. It might
be better to fix the ordering of events_hi, events_lo, cp_events_hi and
cp_events_lo in struct mdp_superblock_s / typedef mdp_super_t.
Signed-off-by: David Howells <dhowells@redhat.com>
Acked-by: NeilBrown <neilb@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to '')
0 files changed, 0 insertions, 0 deletions