diff options
| author | Greg Ungerer <gerg@linux-m68k.org> | 2023-09-13 13:58:22 +0200 |
|---|---|---|
| committer | Greg Ungerer <gerg@linux-m68k.org> | 2023-10-23 00:22:22 +0200 |
| commit | 0100f67c46c04628ff4ce81d1f2f04924b83b14e (patch) | |
| tree | 4ad482407520a74d818dc272b1f522401c7dc200 /arch/m68k | |
| parent | Linux 6.6-rc7 (diff) | |
| download | linux-0100f67c46c04628ff4ce81d1f2f04924b83b14e.tar.xz linux-0100f67c46c04628ff4ce81d1f2f04924b83b14e.zip | |
m68knommu: improve config ROM setting defaults
The ROM region configuration settings used on some nommu m68k systems
(historically mostly 68328 (Dragonball) CPUs) default to an address
of 0. That can easily clash with default RAM address settings which
also default to 0. Of course that is invalid and those ranges overlap,
but if you make no value selection that is what you end up with. Those
default values produce a valid configuration but will fail compilation
like this:
m68k-linux-ld: section .rodata VMA [0000000000001000,0000000000262227] overlaps section .text VMA [0000000000000400,0000000000455e7f]
Looking at the platforms that use the ROM region configuration settings
it is clear that we can choose much better defaults than 0. By far the
most common ROM region settings are these:
CONFIG_ROMVEC=0x10c10000
CONFIG_ROMSTART=0x10c10400
So lets make these the default values.
It is still possible to configure overlapping ROM and RAM regions, but
at least the default selections are now valid.
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202305301407.z33zOjcG-lkp@intel.com/
Signed-off-by: Greg Ungerer <gerg@linux-m68k.org>
Diffstat (limited to 'arch/m68k')
| -rw-r--r-- | arch/m68k/Kconfig.machine | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/m68k/Kconfig.machine b/arch/m68k/Kconfig.machine index 1f3574aef638..d06b1c5d9b0c 100644 --- a/arch/m68k/Kconfig.machine +++ b/arch/m68k/Kconfig.machine @@ -441,7 +441,7 @@ config ROM config ROMVEC hex "Address of the base of the ROM vectors" - default "0" + default "0x10c10000" depends on ROM help This is almost always the same as the base of the ROM. Since on all @@ -450,7 +450,7 @@ config ROMVEC config ROMSTART hex "Address of the base of system image in ROM" - default "0x400" + default "0x10c10400" depends on ROM help Define the start address of the system image in ROM. Commonly this |