diff options
| author | Finn Thain <fthain@telegraphics.com.au> | 2020-05-31 01:12:13 +0200 |
|---|---|---|
| committer | Geert Uytterhoeven <geert@linux-m68k.org> | 2020-07-13 11:39:13 +0200 |
| commit | adc19b2e314b3883a22e4f51654da4e6d8102d5d (patch) | |
| tree | a2c6e3932fddd0b48cf6d62c3300c170adc64606 /arch/m68k | |
| parent | m68k: mac: Fix IOP status/control register writes (diff) | |
| download | linux-adc19b2e314b3883a22e4f51654da4e6d8102d5d.tar.xz linux-adc19b2e314b3883a22e4f51654da4e6d8102d5d.zip | |
m68k: mac: Don't send uninitialized data in IOP message reply
Clear the message reply before calling iop_complete(). This code path is
not normally executed but should that happen let's arrange for consistent
behaviour from the IOP.
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Tested-by: Stan Johnson <userm57@yahoo.com>
Cc: Joshua Thompson <funaho@jurai.org>
Link: https://lore.kernel.org/r/8e35df4d193b082cb6285b1f30c949ff7e30e99e.1590880333.git.fthain@telegraphics.com.au
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Diffstat (limited to 'arch/m68k')
| -rw-r--r-- | arch/m68k/mac/iop.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/arch/m68k/mac/iop.c b/arch/m68k/mac/iop.c index bfc8daf50744..8844963eea75 100644 --- a/arch/m68k/mac/iop.c +++ b/arch/m68k/mac/iop.c @@ -449,6 +449,7 @@ static void iop_handle_recv(uint iop_num, uint chan) iop_pr_debug("unclaimed message on iop_num %d chan %d\n", iop_num, chan); iop_pr_debug("%*ph\n", IOP_MSG_LEN, msg->message); + memset(msg->reply, 0, IOP_MSG_LEN); iop_complete_message(msg); } } |