diff options
| author | Geert Uytterhoeven <geert@linux-m68k.org> | 2023-09-13 16:08:29 +0200 |
|---|---|---|
| committer | Geert Uytterhoeven <geert@linux-m68k.org> | 2023-10-06 10:03:03 +0200 |
| commit | 2e195ea7e95b5360f5e4d9c6a89dbcc4eaf70d36 (patch) | |
| tree | 3562a9d0c0b8ee865cc2b9fe6da88d1439a2a12e /arch/m68k | |
| parent | m68k: sun3: Improve Sun3/3x DVMA abstraction in <asm/dvma.h> (diff) | |
| download | linux-2e195ea7e95b5360f5e4d9c6a89dbcc4eaf70d36.tar.xz linux-2e195ea7e95b5360f5e4d9c6a89dbcc4eaf70d36.zip | |
m68k: sun3: Fix context restore in flush_tlb_range()
When building with W=1:
In file included from arch/m68k/kernel/traps.c:42:
arch/m68k/include/asm/tlbflush.h: In function ‘flush_tlb_range’:
arch/m68k/include/asm/tlbflush.h:191:28: warning: variable ‘oldctx’ set but not used [-Wunused-but-set-variable]
191 | unsigned char seg, oldctx;
| ^~~~~~
Indeed, the old context is saved, but never restored. Fix this by
adding the missing call to sun3_put_context().
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/ea859b7850e061e0f7fb3fca64d9f8e6d1c0d2ad.1694613528.git.geert@linux-m68k.org
Diffstat (limited to 'arch/m68k')
| -rw-r--r-- | arch/m68k/include/asm/tlbflush.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/arch/m68k/include/asm/tlbflush.h b/arch/m68k/include/asm/tlbflush.h index b882e2f4f551..3ab329a03c76 100644 --- a/arch/m68k/include/asm/tlbflush.h +++ b/arch/m68k/include/asm/tlbflush.h @@ -208,6 +208,7 @@ static inline void flush_tlb_range (struct vm_area_struct *vma, next: start += SUN3_PMEG_SIZE; } + sun3_put_context(oldctx); } static inline void flush_tlb_kernel_range(unsigned long start, unsigned long end) |