diff options
| author | Kees Cook <keescook@chromium.org> | 2016-06-02 21:33:44 +0200 |
|---|---|---|
| committer | Kees Cook <keescook@chromium.org> | 2016-06-14 19:54:44 +0200 |
| commit | 2ac3c8d18ed136827ad41786f30c6ed396429660 (patch) | |
| tree | 90df0c0d779c556a9942360283178a29ec57e60b /arch/mips/kernel/ptrace.c | |
| parent | arm64/ptrace: run seccomp after ptrace (diff) | |
| download | linux-2ac3c8d18ed136827ad41786f30c6ed396429660.tar.xz linux-2ac3c8d18ed136827ad41786f30c6ed396429660.zip | |
MIPS/ptrace: run seccomp after ptrace
Close the hole where ptrace can change a syscall out from under seccomp.
Signed-off-by: Kees Cook <keescook@chromium.org>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: "Maciej W. Rozycki" <macro@imgtec.com>
Cc: James Hogan <james.hogan@imgtec.com>
Cc: linux-mips@linux-mips.org
Diffstat (limited to 'arch/mips/kernel/ptrace.c')
| -rw-r--r-- | arch/mips/kernel/ptrace.c | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/arch/mips/kernel/ptrace.c b/arch/mips/kernel/ptrace.c index c50af846ecf9..6103b24d1bfc 100644 --- a/arch/mips/kernel/ptrace.c +++ b/arch/mips/kernel/ptrace.c @@ -888,17 +888,16 @@ long arch_ptrace(struct task_struct *child, long request, */ asmlinkage long syscall_trace_enter(struct pt_regs *regs, long syscall) { - long ret = 0; user_exit(); current_thread_info()->syscall = syscall; - if (secure_computing(NULL) == -1) - return -1; - if (test_thread_flag(TIF_SYSCALL_TRACE) && tracehook_report_syscall_entry(regs)) - ret = -1; + return -1; + + if (secure_computing(NULL) == -1) + return -1; if (unlikely(test_thread_flag(TIF_SYSCALL_TRACEPOINT))) trace_sys_enter(regs, regs->regs[2]); |