diff options
| author | Janusz Krzysztofik <jmkrzyszt@gmail.com> | 2018-10-02 11:45:29 +0200 |
|---|---|---|
| committer | Tony Lindgren <tony@atomide.com> | 2018-10-04 16:29:41 +0200 |
| commit | ab6ead7d07ca87e3e66e6d524c8aa311732878de (patch) | |
| tree | e3ca862d6082694046bddf5e1d29cd4c9609cea2 /arch/mips/kernel/r4k_fpu.S | |
| parent | ARM: OMAP1: ams-delta: Don't request unused GPIOs (diff) | |
| download | linux-ab6ead7d07ca87e3e66e6d524c8aa311732878de.tar.xz linux-ab6ead7d07ca87e3e66e6d524c8aa311732878de.zip | |
ARM: OMAP1: ams-delta: Fix impossible .irq < 0
Since the very beginning, unsigned int .irq member of struct
plat_serial8250_port introduced by commit eff443df679e ("OMAP1:
AMS_DELTA: add modem support") was statically initialized to a negative
value -EINVAL. Moreover, commit 0812db943748 ("ARM: OMAP1: ams-delta:
assign MODEM IRQ from GPIO descriptor") has introduced some new code
which checks for that member carrying a negative value which is
impossible.
Use IRQ_NOTCONNECTED instead of -EINVAL. Also, drop the valueless check
and let the modem device be registered regardless of .irq value, and
the value handled by "serial8250" driver.
Fixes: 0812db943748 ("ARM: OMAP1: ams-delta: assign MODEM IRQ from GPIO descriptor")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Janusz Krzysztofik <jmkrzyszt@gmail.com>
Acked-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Diffstat (limited to 'arch/mips/kernel/r4k_fpu.S')
0 files changed, 0 insertions, 0 deletions