summaryrefslogtreecommitdiffstats
path: root/arch/mips/kernel/vpe-mt.c
diff options
context:
space:
mode:
authorYang Yingliang <yangyingliang@huawei.com>2022-11-04 04:39:44 +0100
committerThomas Bogendoerfer <tsbogend@alpha.franken.de>2022-11-22 13:09:04 +0100
commit5822e8cc84ee37338ab0bdc3124f6eec04dc232d (patch)
tree14abeaebae6e24c62bf2ad9b6183963b2d8c6a2e /arch/mips/kernel/vpe-mt.c
parentdt-bindings: mips: brcm: add Broadcom SoCs bindings (diff)
downloadlinux-5822e8cc84ee37338ab0bdc3124f6eec04dc232d.tar.xz
linux-5822e8cc84ee37338ab0bdc3124f6eec04dc232d.zip
MIPS: vpe-mt: fix possible memory leak while module exiting
Afer commit 1fa5ae857bb1 ("driver core: get rid of struct device's bus_id string array"), the name of device is allocated dynamically, it need be freed when module exiting, call put_device() to give up reference, so that it can be freed in kobject_cleanup() when the refcount hit to 0. The vpe_device is static, so remove kfree() from vpe_device_release(). Fixes: 1fa5ae857bb1 ("driver core: get rid of struct device's bus_id string array") Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Diffstat (limited to 'arch/mips/kernel/vpe-mt.c')
-rw-r--r--arch/mips/kernel/vpe-mt.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/mips/kernel/vpe-mt.c b/arch/mips/kernel/vpe-mt.c
index bad6b0891b2b..84a82b551ec3 100644
--- a/arch/mips/kernel/vpe-mt.c
+++ b/arch/mips/kernel/vpe-mt.c
@@ -313,7 +313,6 @@ ATTRIBUTE_GROUPS(vpe);
static void vpe_device_release(struct device *cd)
{
- kfree(cd);
}
static struct class vpe_class = {
@@ -497,6 +496,7 @@ out_dev:
device_del(&vpe_device);
out_class:
+ put_device(&vpe_device);
class_unregister(&vpe_class);
out_chrdev:
@@ -509,7 +509,7 @@ void __exit vpe_module_exit(void)
{
struct vpe *v, *n;
- device_del(&vpe_device);
+ device_unregister(&vpe_device);
class_unregister(&vpe_class);
unregister_chrdev(major, VPE_MODULE_NAME);