diff options
| author | Hauke Mehrtens <hauke@hauke-m.de> | 2019-06-17 00:30:39 +0200 |
|---|---|---|
| committer | Paul Burton <paul.burton@mips.com> | 2019-06-17 00:51:22 +0200 |
| commit | d6ed083f5cc621e15c15b56c3b585fd524dbcb0f (patch) | |
| tree | 889dfff787c4d8fca0c46106272098141d7ce8d8 /arch/mips/mm | |
| parent | Linux 5.2-rc5 (diff) | |
| download | linux-d6ed083f5cc621e15c15b56c3b585fd524dbcb0f.tar.xz linux-d6ed083f5cc621e15c15b56c3b585fd524dbcb0f.zip | |
MIPS: Fix bounds check virt_addr_valid
The bounds check used the uninitialized variable vaddr, it should use
the given parameter kaddr instead. When using the uninitialized value
the compiler assumed it to be 0 and optimized this function to just
return 0 in all cases.
This should make the function check the range of the given address and
only do the page map check in case it is in the expected range of
virtual addresses.
Fixes: 074a1e1167af ("MIPS: Bounds check virt_addr_valid")
Cc: stable@vger.kernel.org # v4.12+
Cc: Paul Burton <paul.burton@mips.com>
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Signed-off-by: Paul Burton <paul.burton@mips.com>
Cc: ralf@linux-mips.org
Cc: jhogan@kernel.org
Cc: f4bug@amsat.org
Cc: linux-mips@vger.kernel.org
Cc: ysu@wavecomp.com
Cc: jcristau@debian.org
Diffstat (limited to 'arch/mips/mm')
| -rw-r--r-- | arch/mips/mm/mmap.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/mips/mm/mmap.c b/arch/mips/mm/mmap.c index 50ee7213b432..d79f2b432318 100644 --- a/arch/mips/mm/mmap.c +++ b/arch/mips/mm/mmap.c @@ -203,7 +203,7 @@ unsigned long arch_randomize_brk(struct mm_struct *mm) bool __virt_addr_valid(const volatile void *kaddr) { - unsigned long vaddr = (unsigned long)vaddr; + unsigned long vaddr = (unsigned long)kaddr; if ((vaddr < PAGE_OFFSET) || (vaddr >= MAP_BASE)) return false; |