diff options
| author | John David Anglin <dave.anglin@bell.net> | 2013-04-23 22:42:07 +0200 |
|---|---|---|
| committer | Helge Deller <deller@gmx.de> | 2013-04-25 22:37:00 +0200 |
| commit | bda079d336cd8183e1d844a265ea87ae3e1bbe78 (patch) | |
| tree | 0e2a80cf2dacd44299e55baa485dd7dd4a2ff3d9 /arch/parisc/kernel/cache.c | |
| parent | parisc: disable -mlong-calls compiler option for kernel modules (diff) | |
| download | linux-bda079d336cd8183e1d844a265ea87ae3e1bbe78.tar.xz linux-bda079d336cd8183e1d844a265ea87ae3e1bbe78.zip | |
parisc: use spin_lock_irqsave/spin_unlock_irqrestore for PTE updates
User applications running on SMP kernels have long suffered from instability
and random segmentation faults. This patch improves the situation although
there is more work to be done.
One of the problems is the various routines in pgtable.h that update page table
entries use different locking mechanisms, or no lock at all (set_pte_at). This
change modifies the routines to all use the same lock pa_dbit_lock. This lock
is used for dirty bit updates in the interruption code. The patch also purges
the TLB entries associated with the PTE to ensure that inconsistent values are
not used after the page table entry is updated. The UP and SMP code are now
identical.
The change also includes a minor update to the purge_tlb_entries function in
cache.c to improve its efficiency.
Signed-off-by: John David Anglin <dave.anglin@bell.net>
Cc: Helge Deller <deller@gmx.de>
Signed-off-by: Helge Deller <deller@gmx.de>
Diffstat (limited to '')
| -rw-r--r-- | arch/parisc/kernel/cache.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/arch/parisc/kernel/cache.c b/arch/parisc/kernel/cache.c index 4b12890642eb..83ded26cad06 100644 --- a/arch/parisc/kernel/cache.c +++ b/arch/parisc/kernel/cache.c @@ -421,14 +421,11 @@ void purge_tlb_entries(struct mm_struct *mm, unsigned long addr) /* Note: purge_tlb_entries can be called at startup with no context. */ - /* Disable preemption while we play with %sr1. */ - preempt_disable(); - mtsp(mm->context, 1); purge_tlb_start(flags); + mtsp(mm->context, 1); pdtlb(addr); pitlb(addr); purge_tlb_end(flags); - preempt_enable(); } EXPORT_SYMBOL(purge_tlb_entries); |