summaryrefslogtreecommitdiffstats
path: root/arch/powerpc/kernel/watchdog.c
diff options
context:
space:
mode:
authorMichael Ellerman <mpe@ellerman.id.au>2017-10-12 06:44:33 +0200
committerMichael Ellerman <mpe@ellerman.id.au>2018-01-28 07:08:28 +0100
commit3ba45b7e46e2ae7c059f3335120aed5e2c749bd9 (patch)
treecdc8dd2bd3b3b0ed509df8eb0b99e180c516d499 /arch/powerpc/kernel/watchdog.c
parentpowerpc/watchdog: Tweak watchdog printks (diff)
downloadlinux-3ba45b7e46e2ae7c059f3335120aed5e2c749bd9.tar.xz
linux-3ba45b7e46e2ae7c059f3335120aed5e2c749bd9.zip
powerpc/watchdog: regs can't be null in soft_nmi_interrupt()
soft_nmi_interrupt() is called directly from the asm exception handling code, which passes regs as a pointer to the stack. So regs can't be NULL, it may be full of junk, but that's a separate problem. Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Diffstat (limited to 'arch/powerpc/kernel/watchdog.c')
-rw-r--r--arch/powerpc/kernel/watchdog.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/arch/powerpc/kernel/watchdog.c b/arch/powerpc/kernel/watchdog.c
index c00baea616ba..80a467eb532a 100644
--- a/arch/powerpc/kernel/watchdog.c
+++ b/arch/powerpc/kernel/watchdog.c
@@ -257,10 +257,7 @@ void soft_nmi_interrupt(struct pt_regs *regs)
pr_emerg("CPU %d self-detected hard LOCKUP\n", cpu);
print_modules();
print_irqtrace_events(current);
- if (regs)
- show_regs(regs);
- else
- dump_stack();
+ show_regs(regs);
wd_smp_unlock(&flags);