diff options
author | Li Zhong <zhong@linux.vnet.ibm.com> | 2011-12-18 17:03:04 +0100 |
---|---|---|
committer | Benjamin Herrenschmidt <benh@kernel.crashing.org> | 2012-01-03 02:09:27 +0100 |
commit | e4f387d8db3ba3c2dae4d8bdfe7bb5f4fe1bcb0d (patch) | |
tree | 148f0524d6f8413dbc5ed09e9bf056e2592649e6 /arch/powerpc/sysdev/fsl_pci.c | |
parent | offb: Fix setting of the pseudo-palette for >8bpp (diff) | |
download | linux-e4f387d8db3ba3c2dae4d8bdfe7bb5f4fe1bcb0d.tar.xz linux-e4f387d8db3ba3c2dae4d8bdfe7bb5f4fe1bcb0d.zip |
powerpc: Fix unpaired probe_hcall_entry and probe_hcall_exit
Unpaired calling of probe_hcall_entry and probe_hcall_exit might happen
as following, which could cause incorrect preempt count.
__trace_hcall_entry => trace_hcall_entry -> probe_hcall_entry =>
get_cpu_var => preempt_disable
__trace_hcall_exit => trace_hcall_exit -> probe_hcall_exit =>
put_cpu_var => preempt_enable
where:
A => B and A -> B means A calls B, but
=> means A will call B through function name, and B will definitely be
called.
-> means A will call B through function pointer, so B might not be
called if the function pointer is not set.
So error happens when only one of probe_hcall_entry and probe_hcall_exit
get called during a hcall.
This patch tries to move the preempt count operations from
probe_hcall_entry and probe_hcall_exit to its callers.
Reported-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Li Zhong <zhong@linux.vnet.ibm.com>
Tested-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
CC: stable@kernel.org [v2.6.32+]
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Diffstat (limited to 'arch/powerpc/sysdev/fsl_pci.c')
0 files changed, 0 insertions, 0 deletions