diff options
| author | Michael Ellerman <michael@ellerman.id.au> | 2008-05-26 04:12:32 +0200 |
|---|---|---|
| committer | Paul Mackerras <paulus@samba.org> | 2008-06-09 05:51:16 +0200 |
| commit | 19fc65b5251dfd90312ae0142cc8650cd273e6a6 (patch) | |
| tree | 2b61ab4405dce8bd17e76584821856ea3baabd88 /arch/powerpc/sysdev/tsi108_pci.c | |
| parent | powerpc: Rework qe_ic_init() so we can avoid freeing the irq_host (diff) | |
| download | linux-19fc65b5251dfd90312ae0142cc8650cd273e6a6.tar.xz linux-19fc65b5251dfd90312ae0142cc8650cd273e6a6.zip | |
powerpc: Fix irq_alloc_host() reference counting and callers
When I changed irq_alloc_host() to take an of_node
(52964f87c64e6c6ea671b5bf3030fb1494090a48: "Add an optional
device_node pointer to the irq_host"), I botched the reference
counting semantics.
Stephen pointed out that it's irq_alloc_host()'s business if
it needs to take an additional reference to the device_node,
the caller shouldn't need to care.
Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: Paul Mackerras <paulus@samba.org>
Diffstat (limited to 'arch/powerpc/sysdev/tsi108_pci.c')
| -rw-r--r-- | arch/powerpc/sysdev/tsi108_pci.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/arch/powerpc/sysdev/tsi108_pci.c b/arch/powerpc/sysdev/tsi108_pci.c index ac1a72dc21e5..24e1f5a197ae 100644 --- a/arch/powerpc/sysdev/tsi108_pci.c +++ b/arch/powerpc/sysdev/tsi108_pci.c @@ -426,11 +426,10 @@ void __init tsi108_pci_int_init(struct device_node *node) { DBG("Tsi108_pci_int_init: initializing PCI interrupts\n"); - pci_irq_host = irq_alloc_host(of_node_get(node), IRQ_HOST_MAP_LEGACY, + pci_irq_host = irq_alloc_host(node, IRQ_HOST_MAP_LEGACY, 0, &pci_irq_host_ops, 0); if (pci_irq_host == NULL) { printk(KERN_ERR "pci_irq_host: failed to allocate irq host !\n"); - of_node_put(node); return; } |