diff options
| author | Ravi Bangoria <ravi.bangoria@linux.ibm.com> | 2020-05-14 13:17:40 +0200 |
|---|---|---|
| committer | Michael Ellerman <mpe@ellerman.id.au> | 2020-05-18 16:14:45 +0200 |
| commit | 514db915e7b33e7eaf8e40192b93380f79b319b5 (patch) | |
| tree | 1610520c4f5fa51cf52d44e5973bebc9a8422614 /arch/powerpc/xmon/xmon.c | |
| parent | powerpc/watchpoint: Don't allow concurrent perf and ptrace events (diff) | |
| download | linux-514db915e7b33e7eaf8e40192b93380f79b319b5.tar.xz linux-514db915e7b33e7eaf8e40192b93380f79b319b5.zip | |
powerpc/watchpoint/xmon: Don't allow breakpoint overwriting
Xmon allows overwriting breakpoints because it's supported by only
one DAWR. But with multiple DAWRs, overwriting becomes ambiguous
or unnecessary complicated. So let's not allow it.
Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Reviewed-by: Michael Neuling <mikey@neuling.org>
Link: https://lore.kernel.org/r/20200514111741.97993-16-ravi.bangoria@linux.ibm.com
Diffstat (limited to 'arch/powerpc/xmon/xmon.c')
| -rw-r--r-- | arch/powerpc/xmon/xmon.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c index 30b3e3d99c0d..094bf4715f2c 100644 --- a/arch/powerpc/xmon/xmon.c +++ b/arch/powerpc/xmon/xmon.c @@ -1399,6 +1399,10 @@ bpt_cmds(void) printf("Hardware data breakpoint not supported on this cpu\n"); break; } + if (dabr.enabled) { + printf("Couldn't find free breakpoint register\n"); + break; + } mode = 7; cmd = inchar(); if (cmd == 'r') |